Convert islot_seed to generic_factory #40371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorGgenT
added
the
Code: Infrastructure / Style / Static Analysis
This was referenced May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Move islot_seed to generic_factory"
Purpose of change
Work towards #36851
Describe the solution
Convert
Item_factory::load( islot_seed &slot ... )toislot_seed::load(...)Use mandatory, optional, and assign where appropriate in place of reading directly from the JsonObject.
Add
islot_ammo::deserialize()Use assign to load
itype::seed, instead ofload_islot_optional()Testing
No loading errors running the tests with and without mod JSON.
Test run and pass.
Planting, growing and harvesting crops works as expected.